Add `--from-post=<post_id>` flag to create duplicate posts #154

sagarnasit · 2018-03-14T18:34:05Z

I here modified the create command to generate a duplicate post.

danielbachhuber

👍 Great start! Can you include functional tests too?

danielbachhuber · 2018-03-20T12:37:41Z

src/Post_Command.php

+       *
+       * [--from-post=<post_id>]
+       * : The post id of a post to be duplicated.
+       *


Looks like this is spaces instead of tabs. Can you correct to tabs?

yes, I will correct it.

danielbachhuber · 2018-03-20T12:37:53Z

src/Post_Command.php

+       *     # Create a duplicate post with same post data.
+       *     $ wp post create --from-post=123 --post_title='Different Title'
+       *     Success: Created post 2350.
+       */


Ditto spaces -> tabs.

My bad. I will change it too.

danielbachhuber · 2018-03-20T12:38:07Z

src/Post_Command.php

+                  $post_id  = $post_arr['ID'];
+                  unset( $post_arr['post_date'] );
+                  unset( $post_arr['post_date_gmt'] );
+                  unset( $post_arr['guid'] );


WHy did you decide to skip these values?

This values will be duplicated too. I skip post_date and post_date_gmt so that values can be reset according to the current date at the time of duplicating. Reason to unset guid is that duplicated post guid will same as the original.

If you have any suggestions please let me know.

danielbachhuber · 2018-03-20T12:38:31Z

src/Post_Command.php

+            if( isset( $assoc_args['from-post'] ) ) {
+                  $post     = $this->fetcher->get_check( $assoc_args['from-post'] );
+                  $post_arr = get_object_vars( $post );
+                  $post_id  = $post_arr['ID'];


$post_arr['ID'] should be unset, correct?

yes, you are right. Actually, if we don't unset id it will still generate new id. But, for a safer side, I will make correct it.

danielbachhuber · 2018-03-20T12:39:16Z

src/Post_Command.php

+       * @param $post_id id of the post.
+       * @return array
+       */
+      private function get_metadata( $post_id = null ) {


Instead of making $post_id optional, we should make it required:

get_metadata( $post_id = null )

danielbachhuber · 2018-03-20T12:39:34Z

src/Post_Command.php

+
+                  if ( empty( $assoc_args['meta_input'] ) ) {
+                        $assoc_args['meta_input'] = $this->get_metadata( $post_id );
+                  }


Do we need to persist taxonomy data too?

This part is for overwriting existing metadata if a user wants. Categories and tags can be duplicated too. what are your thoughts about it?

Yes, I think categories and tags should be duplicated too.

sagarnasit · 2018-03-22T05:18:06Z

@danielbachhuber I made changes you asked and added taxonomy duplication as well. I don't have any idea about functional testing so I haven't done testing yet.

schlessera · 2018-03-22T10:16:43Z

@sagarnasit I can help you go through setting up the testing.

You should first check whether you can even run the existing tests.

As the Functional Tests help states, you'll need to prepare your database server first:

Before running the functional tests, you’ll need a MySQL (or MariaDB) user called wp_cli_test with the password password1 that has full privileges on the MySQL database wp_cli_test. Running the following as root in MySQL should do the trick:

GRANT ALL PRIVILEGES ON wp_cli_test.* TO "wp_cli_test"@"localhost" IDENTIFIED BY "password1";

Then, to run the entire test suite:

./vendor/bin/behat --expand

Or to test a single feature:

./vendor/bin/behat features/core.feature

schlessera · 2018-04-02T05:51:52Z

Looking into the Travis failure: #161

schlessera · 2018-04-03T11:08:26Z

@sagarnasit I should have addressed the test failure on PHP 5.3 now. Can you merge latest master into your PR to make the tests pass again?

sagarnasit · 2018-04-14T18:50:21Z

Thanks @schlessera . I also added functional testing as @danielbachhuber said.

schlessera · 2018-04-19T06:35:46Z

features/post-create-duplicate.feature

+      """
+      {TERM_ID}
+      """
+  @require-wp-4.4


Blank line needed between scenarios (above the @require-wp-4.4 tag).

schlessera · 2018-04-19T06:41:57Z

src/Post_Command.php

@@ -171,7 +178,28 @@ public function create( $args, $assoc_args ) {
 		}

 		$array_arguments = array( 'meta_input' );
-		$assoc_args      = \WP_CLI\Utils\parse_shell_arrays( $assoc_args, $array_arguments );
+		$assoc_args = \WP_CLI\Utils\parse_shell_arrays($assoc_args, $array_arguments);


This entire block (lines 181-202) seems to have been inadvertently reformatted to PSR2 with the last commit.

Please adapt the formatting to adhere to WPCS instead.

schlessera · 2018-04-19T06:43:37Z

src/Post_Command.php

+	 *
+	 * @return array
+	 */
+	private function get_tags( $post_id ) {


The code path for tags is not covered by the tests.

schlessera · 2018-04-19T06:44:45Z

@sagarnasit This looks good already. There's some whitespace that got messed up during the last commit that you need to redress, and I would like to also have a test that covers the "tags" code.

sagarnasit · 2018-04-21T15:21:46Z

@schlessera Added Test for Tags. Looks Good?

schlessera

Code looks good. Only some minor stuff as a final cleanup, and then we can merge.

schlessera · 2018-04-23T18:53:30Z

src/Post_Command.php

+	/**
+	 * Get Tags of a post.
+	 *
+	 * @param $post_id postid of the post.


Should be:

@param $post_id ID of the post.

schlessera · 2018-04-23T18:53:34Z

src/Post_Command.php

+	/**
+	 * Get Categories of a post.
+	 *
+	 * @param $post_id postid of the post.


Should be:

@param $post_id ID of the post.

schlessera · 2018-04-23T18:53:39Z

src/Post_Command.php

+	/**
+	 * Get post metadata.
+	 *
+	 * @param $post_id id of the post.


Should be:

@param $post_id ID of the post.

schlessera · 2018-04-23T18:53:53Z

features/post-create-duplicate.feature

+
+	When I run `wp post term add {POST_ID} post_tag {TAG_ID} --by=id`
+	Then STDOUT should contain:
+      """*


There's a random asterisk added here.

sagarnasit · 2018-04-25T18:53:07Z

@schlessera Made changes you asked for.

schlessera · 2018-05-08T08:05:34Z

Thank you for the pull request, @sagarnasit !

create subcommand extended to generate duplicate post

e9fb3c6

danielbachhuber requested changes Mar 20, 2018

View reviewed changes

schlessera added the command:post-create label Mar 20, 2018

Changes with Taxonomy duplication

fc24f8c

sagarnasit added 2 commits April 1, 2018 15:27

Add Fuctional Test for --from-post

81e4111

Add WP-4.4 Check for Meta Inputs

13b4e61

Merge branch 'master' of github.com:wp-cli/entity-command

b618e95

Add detail in README.md

3f4b03f

schlessera requested changes Apr 19, 2018

View reviewed changes

sagarnasit added 2 commits April 21, 2018 12:11

Fix WPCS

f282a70

Add Tag Test

401cc41

schlessera requested changes Apr 23, 2018

View reviewed changes

Fix Block comment

ffe42d6

schlessera changed the title ~~create subcommand extended to generate duplicate post~~ Add --from-post<post_id> flag to create duplicate posts May 8, 2018

schlessera approved these changes May 8, 2018

View reviewed changes

schlessera changed the title ~~Add --from-post<post_id> flag to create duplicate posts~~ Add --from-post=<post_id> flag to create duplicate posts May 8, 2018

schlessera merged commit cf1741d into wp-cli:master May 8, 2018

schlessera added this to the 1.3.0 milestone May 8, 2018

aaronjorbin mentioned this pull request Feb 24, 2019

Request: Add wp post duplicate #141

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `--from-post=<post_id>` flag to create duplicate posts #154

Add `--from-post=<post_id>` flag to create duplicate posts #154

sagarnasit commented Mar 14, 2018

danielbachhuber left a comment

danielbachhuber Mar 20, 2018

sagarnasit Mar 21, 2018

danielbachhuber Mar 20, 2018

sagarnasit Mar 21, 2018

danielbachhuber Mar 20, 2018

sagarnasit Mar 21, 2018

danielbachhuber Mar 20, 2018

sagarnasit Mar 21, 2018 •

edited

danielbachhuber Mar 20, 2018

sagarnasit Mar 21, 2018

danielbachhuber Mar 20, 2018

sagarnasit Mar 21, 2018

danielbachhuber Mar 21, 2018

sagarnasit commented Mar 22, 2018

schlessera commented Mar 22, 2018 •

edited

schlessera commented Apr 2, 2018 •

edited

schlessera commented Apr 3, 2018

sagarnasit commented Apr 14, 2018 •

edited

schlessera Apr 19, 2018

schlessera Apr 19, 2018

schlessera Apr 19, 2018

schlessera commented Apr 19, 2018

sagarnasit commented Apr 21, 2018

schlessera left a comment •

edited

schlessera Apr 23, 2018

schlessera Apr 23, 2018

schlessera Apr 23, 2018

schlessera Apr 23, 2018

sagarnasit commented Apr 25, 2018

schlessera commented May 8, 2018

Add --from-post=<post_id> flag to create duplicate posts #154

Add --from-post=<post_id> flag to create duplicate posts #154

Conversation

sagarnasit commented Mar 14, 2018

danielbachhuber left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sagarnasit Mar 21, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sagarnasit commented Mar 22, 2018

schlessera commented Mar 22, 2018 • edited

schlessera commented Apr 2, 2018 • edited

schlessera commented Apr 3, 2018

sagarnasit commented Apr 14, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

schlessera commented Apr 19, 2018

sagarnasit commented Apr 21, 2018

schlessera left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sagarnasit commented Apr 25, 2018

schlessera commented May 8, 2018

Add `--from-post=<post_id>` flag to create duplicate posts #154

Add `--from-post=<post_id>` flag to create duplicate posts #154

sagarnasit Mar 21, 2018 •

edited

schlessera commented Mar 22, 2018 •

edited

schlessera commented Apr 2, 2018 •

edited

sagarnasit commented Apr 14, 2018 •

edited

schlessera left a comment •

edited